Craig Welch updated YARN-2505:
    Attachment: YARN-2505.8.patch

Attached is patch implementing all of [~leftnoteasy] 's recommendations except 
2.1 It's better to save the reference to RMNodeLabelsManager instead of get it 
in RMContext everytime. 
I actually don't think so - to do that requires adding a bunch of code for 
member/checking for null/ etc/etc for an operation which will be completely 
lost in the overall cost of the action (io, etc).  More importantly, that then 
links the lifetime of the nodelabel manager to the lifetime of the resource 
manager web app, which might be ok at the moment, but it could change sometime 
down the line and then there would be a confusing bug to figure out and resolve.

> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.1.patch, YARN-2505.3.patch, YARN-2505.4.patch, 
> YARN-2505.5.patch, YARN-2505.6.patch, YARN-2505.7.patch, YARN-2505.8.patch, 
> YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to