Craig Welch commented on YARN-2505:

[~leftnoteasy] I appreciate your reviewing this change and I understand your 
perspective on this particular aspect of it - but I think that caching the node 
label manager here is premature optimization that adds unnecessary complexity 
and future risk where there isn't a good reason to do so.  You'll notice that 
other implementations in the service are taking the same approach and 
retrieving references as needed without caching.  I'm planning to leave it 
as/is in this respect.  

> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.1.patch, YARN-2505.3.patch, YARN-2505.4.patch, 
> YARN-2505.5.patch, YARN-2505.6.patch, YARN-2505.7.patch, YARN-2505.8.patch, 
> YARN-2505.9.patch, YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to