[ 
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184140#comment-14184140
 ] 

Naganarasimha G R commented on YARN-2495:
-----------------------------------------

{quote}
3) NodeManager:
createNodeStatusUpdater : I suggest to create a overload method without the 
nodeLabelsProviderService to avoid lots of changes in test/mock classes.
{quote}
NodeManager during initservice method is calling a protected 
createNodeStatusUpdater method. So even though we add overloaded method 
initservice will call the method which takes
nodeLabelsProviderService or we need to add code like 
{quote} 
        if(null==nodeLabelsProviderService){
                createNodeStatusUpdater(context, dispatcher, nodeHealthChecker);
        }else{
                createNodeStatusUpdater(context, dispatcher, 
nodeHealthChecker,nodeLabelsProviderService);
        }
{quote} 
is it ok ?

> Allow admin specify labels in each NM (Distributed configuration)
> -----------------------------------------------------------------
>
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml or using script 
> suggested by [~aw])
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to