[
https://issues.apache.org/jira/browse/YARN-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184780#comment-14184780
]
Naganarasimha G R commented on YARN-2729:
-----------------------------------------
Hi [~Wangda],
bq. And you need make checkAndThrowLabelName in CommonsNodeLabelsManager
public, check the labels if valid before send to RM.
Two concerns if we do this:
1. Two times labels will get validated, once in NM and once in
RM(NodeLabelsManager.replaceNodeLabels ). And anyway as the exception message
is planned to be propagated till NM and getting logged in NM, would this be
required.?
2. Currently checkAndThrowLabelName is validating and throwing exception for a
singe label, i think it would better to accept a collection and show that which
all labels in the collection are not valid. So that user need not wait till
multiple timer runs to identify all the set of valid labels. so was planning to
rename the method to $$ validateLabels(Collection<String> labels) $$ and make
it static to get it accessible for (conf & script)NodeLabelsProvider (if this
basic validation is required in NM too)
> Support script based NodeLabelsProvider Interface in Distributed Node Label
> Configuration Setup
> -----------------------------------------------------------------------------------------------
>
> Key: YARN-2729
> URL: https://issues.apache.org/jira/browse/YARN-2729
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Attachments: YARN-2729.20141023-1.patch, YARN-2729.20141024-1.patch
>
>
> Support script based NodeLabelsProvider Interface in Distributed Node Label
> Configuration Setup .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
