[ 
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186276#comment-14186276
 ] 

zhihai xu commented on YARN-2753:
---------------------------------

I added a unit test in new patch YARN-2753.002.patch, without the fix, there 
will be NPE :
{code}
java.lang.NullPointerException: null
        at 
org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.checkRemoveLabelsFromNode(CommonNodeLabelsManager.java:461)
        at 
org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.removeLabelsFromNode(CommonNodeLabelsManager.java:516)
        at 
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.RMNodeLabelsManager.removeLabelsFromNode(RMNodeLabelsManager.java:139)
        at 
org.apache.hadoop.yarn.server.resourcemanager.nodelabels.TestRMNodeLabelsManager.testRemoveLabelsFromNode(TestRMNodeLabelsManager.java:412)
{code}

> potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager
> ---------------------------------------------------------------------
>
>                 Key: YARN-2753
>                 URL: https://issues.apache.org/jira/browse/YARN-2753
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2753.000.patch, YARN-2753.001.patch, 
> YARN-2753.002.patch
>
>
> potential NPE(NullPointerException) in checkRemoveLabelsFromNode of 
> CommonNodeLabelsManager.
> It because when a Node is created, Node.labels can be null.
> In this case, nm.labels; may be null.
> So we need check originalLabels not null before use 
> it(originalLabels.containsAll).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to