Rohith commented on YARN-1813:

Thanks Tshuyosh for rebasing patch!!
Some minor comments
1. I think Logging both messages "Logs not available at " and "Permission 
denied" makes contradictory. Only Permission denied is sufficient.
2. AggregatedLogsBlock.java not changed but it imports AccessControlException. 
Does it required?
3. If app is submitted but not yet started? Here also log will be displayed as 
"Log aggregation has not completed or is not enabled". I think we can log all 
the possible reason why logs not available.

> Better error message for "yarn logs" when permission denied
> -----------------------------------------------------------
>                 Key: YARN-1813
>                 URL: https://issues.apache.org/jira/browse/YARN-1813
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.3.0, 2.4.1, 2.5.1
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: YARN-1813.1.patch, YARN-1813.2.patch, YARN-1813.2.patch, 
> YARN-1813.3.patch, YARN-1813.4.patch, YARN-1813.5.patch
> I ran some MR jobs as the "hdfs" user, and then forgot to sudo -u when 
> grabbing the logs. "yarn logs" prints an error message like the following:
> {noformat}
> [andrew.wang@a2402 ~]$ yarn logs -applicationId application_1394482121761_0010
> 14/03/10 16:05:10 INFO client.RMProxy: Connecting to ResourceManager at 
> a2402.halxg.cloudera.com/
> Logs not available at 
> /tmp/logs/andrew.wang/logs/application_1394482121761_0010
> Log aggregation has not completed or is not enabled.
> {noformat}
> It'd be nicer if it said "Permission denied" or "AccessControlException" or 
> something like that instead, since that's the real issue.

This message was sent by Atlassian JIRA

Reply via email to