[
https://issues.apache.org/jira/browse/YARN-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186983#comment-14186983
]
Advertising
Sangjin Lee commented on YARN-2742:
-----------------------------------
Thanks for the patch [~ywskycn]!
+1 in terms of using \s* to cover these cases.
I'm comfortable with also making the unit match case-insensitive, but I'd like
to hear others' thoughts on that.
> FairSchedulerConfiguration fails to parse if there is extra space between
> value and unit
> ----------------------------------------------------------------------------------------
>
> Key: YARN-2742
> URL: https://issues.apache.org/jira/browse/YARN-2742
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.4.0
> Reporter: Sangjin Lee
> Assignee: Wei Yan
> Priority: Minor
> Attachments: YARN-2742-1.patch
>
>
> FairSchedulerConfiguration is very strict about the number of space
> characters between the value and the unit: 0 or 1 space.
> For example, for values like the following:
> {noformat}
> <maxResources>4096 mb, 2 vcores<maxResources>
> {noformat}
> (note 2 spaces)
> This above line fails to parse:
> {noformat}
> 2014-10-24 22:56:40,802 ERROR
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService:
> Failed to reload fair scheduler config file - will use existing allocations.
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationConfigurationException:
> Missing resource: mb
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerConfiguration.findResource(FairSchedulerConfiguration.java:247)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerConfiguration.parseResourceConfigValue(FairSchedulerConfiguration.java:231)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.loadQueue(AllocationFileLoaderService.java:347)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.loadQueue(AllocationFileLoaderService.java:381)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService.reloadAllocations(AllocationFileLoaderService.java:293)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.AllocationFileLoaderService$1.run(AllocationFileLoaderService.java:117)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
