[
https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wangda Tan updated YARN-2753:
-----------------------------
Summary: Fix potential issues and code clean up for *NodeLabelsManager
(was: Shouldn't change the value in labelCollections if the key already exists
and potential NPE at CommonNodeLabelsManager.)
> Fix potential issues and code clean up for *NodeLabelsManager
> -------------------------------------------------------------
>
> Key: YARN-2753
> URL: https://issues.apache.org/jira/browse/YARN-2753
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-2753.000.patch, YARN-2753.001.patch,
> YARN-2753.002.patch, YARN-2753.003.patch
>
>
> CommonNodeLabelsManager#addToCluserNodeLabels should not change the value in
> labelCollections if the key already exists otherwise the Label.resource will
> be changed(reset).
> potential NPE(NullPointerException) in checkRemoveLabelsFromNode of
> CommonNodeLabelsManager.
> because when a Node is created, Node.labels can be null.
> In this case, nm.labels; may be null.
> So we need check originalLabels not null before use
> it(originalLabels.containsAll).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
