Xuan Gong commented on YARN-2647:

Thanks for the patch. [~sunilg].

The patch looks good overall. I only have one comment.
This check seems unnecessary
    if (args.length > 0 && args[0].equalsIgnoreCase(QUEUE)) {
    } else {
      syserr.println("Invalid Command usage. Command must start with 'queue'");
      return exitCode;

If we did not call command: yarn queue,  this class will not be used. So, this 
check is not necessary. We do have such check in ApplicationCLI. Because 
command: yarn application and command: yarn applicationattempt will use the 
same ApplicationCLI class. So, they need to do this.

Also, could you create a patch for branch-2, please ? The latest patch can not 
apply to branch-2. 

> Add yarn queue CLI to get queue infos
> -------------------------------------
>                 Key: YARN-2647
>                 URL: https://issues.apache.org/jira/browse/YARN-2647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2647.patch, 0002-YARN-2647.patch, 
> 0003-YARN-2647.patch, 0004-YARN-2647.patch, 0005-YARN-2647.patch, 
> 0006-YARN-2647.patch

This message was sent by Atlassian JIRA

Reply via email to