[
https://issues.apache.org/jira/browse/YARN-2765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187955#comment-14187955
]
Tsuyoshi OZAWA commented on YARN-2765:
--------------------------------------
[~jlowe], great work! It looks good to me overall including error handling and
resource management.
Minor nits:
How about adding helper methods like getKeyPrefix/getNodePath for getting key
prefix and node path? ZKRMStateStore also does so.
{code}
String keyPrefix = RM_APP_ROOT + "/" + appId + "/";
...
String appKey = RM_APP_ROOT + "/" + appId
{code}
I found that the patch includes lots hard-coded "/". I think it's better to
have private field SEPARATOR = "/".
> Add leveldb-based implementation for RMStateStore
> -------------------------------------------------
>
> Key: YARN-2765
> URL: https://issues.apache.org/jira/browse/YARN-2765
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: YARN-2765.patch
>
>
> It would be nice to have a leveldb option to the resourcemanager recovery
> store. Leveldb would provide some benefits over the existing filesystem store
> such as better support for atomic operations, fewer I/O ops per state update,
> and far fewer total files on the filesystem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
