[ 
https://issues.apache.org/jira/browse/YARN-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188656#comment-14188656
 ] 

Zhijie Shen commented on YARN-2766:
-----------------------------------

[~rkanter], thanks for reporting the test failure. I can reproduce the same 
failure with JDK 8, but think about the problem again: it seems to be useless 
to return the map collection from ApplicationHistoryManager. And it creates the 
problem that we simply call .value() to get all report objects, making the 
order of the report objects are unpredictable on CLI or web services output. 
IMHO, ApplicationHistoryManager should return a sorted list directly.

> [JDK 8] TestApplicationHistoryClientService fails
> -------------------------------------------------
>
>                 Key: YARN-2766
>                 URL: https://issues.apache.org/jira/browse/YARN-2766
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.6.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: YARN-2766.patch
>
>
> {{TestApplicationHistoryClientService.testContainers}} and 
> {{TestApplicationHistoryClientService.testApplicationAttempts}} both fail 
> because the test assertions are assuming a returned Collection is in a 
> certain order.  The collection comes from a HashMap, so the order is not 
> guaranteed, plus, according to [this 
> page|http://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html],
>  there are situations where the iteration order of a HashMap will be 
> different between Java 7 and 8.
> We should fix the test code to not assume a specific ordering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to