[ https://issues.apache.org/jira/browse/YARN-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188796#comment-14188796 ]
Zhijie Shen commented on YARN-2769: ----------------------------------- +1. The fix makes sense, and we have the test to cover the code path on windows. Will commit the patch. > Timeline server domain not set correctly when using shell_command on Windows > ---------------------------------------------------------------------------- > > Key: YARN-2769 > URL: https://issues.apache.org/jira/browse/YARN-2769 > Project: Hadoop YARN > Issue Type: Bug > Components: applications/distributed-shell > Reporter: Varun Vasudev > Assignee: Varun Vasudev > Attachments: apache-yarn-2769.0.patch > > > The bug is caught by one of the unit tests which fails. > {noformat} > Running > org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 37.661 sec > <<< FAILURE! - in org.apache.hadoop.yarn.applications.distribut > testDSShellWithDomain(org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell) > Time elapsed: 37.366 sec <<< FAILURE! > org.junit.ComparisonFailure: expected:<[TEST_DOMAIN]> but was:<[DEFAULT]> > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testDSShell(TestDistributedShell.java:290) > at > org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell.testDSShellWithDomain(TestDistributedShell.java:179) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)