Vinod Kumar Vavilapalli commented on YARN-2772:

 I propose the following:
 - Rename the "domain" and "create" options to be "timeline_domain_id" and 
"should_create_timeline_domain" respectively.
 - Modify option description of view_acls and modify_acls to say that they are 
only needed if should_create_timeline_domain is true
 - Modify description of {{timeline_domain_id}} to say that it is optional and 
the it will use the "DEFAULT" timeline-domain by default
 - If {{should_create_timeline_domain}} is off, we should validate on the 
client to see if the domain really exists or not and fail the submission if not 
with a message saying "The passed timeline-domain doesn't exist. Either pass an 
existing timeline-domain_id or set  should_create_timeline_domain to true".
 - If {{should_create_timeline_domain}} is on, and the user passes an existing 
timeline-domain-id, we should fail the submission and say "The passed 
timeline-domain already exists. Either pass an new timeline-domain_id or set  
should_create_timeline_domain to false"

> DistributedShell's timeline related options are not clear
> ---------------------------------------------------------
>                 Key: YARN-2772
>                 URL: https://issues.apache.org/jira/browse/YARN-2772
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications/distributed-shell
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
> The new options "domain" and "create" options - they are not descriptive at 
> all. It is also not clear when view_acls and modify_acls need to be set.

This message was sent by Atlassian JIRA

Reply via email to