Karthik Kambatla commented on YARN-2186:

Thanks Sangjin. Looks mostly good, but for some minor comments: 
# How about renaming NMUploaderSerivceSCMProtocol to SharedCacheUploader (after 
ResourceTracker) or SharedCacheUploaderProtocol? Accordingly, rename all other 
related classes and proto files? 
# Instead of {{yarn.sharedcache.nodemanager.}}, we should probably call it 
{{yarn.sharedcache.uploader}} to avoid confusion? 
# As per our offline discussions, it would be nice to add a way for the NM to 
ask the SCM whether it should upload a resource to the shared-cache or not. For 
now, this could be always yes. In the future, we can add a pluggable policy 
that the SCM would consult to answer the NM.
# NMCacheUploaderSCMProtocolPBClientImpl#close should set {{this.proxy}} to 
null after calling stopProxy.
# NMCacheUploaderSCMProtocolService:
## TODOs should have an associated follow-up JIRA and reference in the code so 
we don't forget
## serviceStop should set {{this.server}} to null after calling 

> Node Manager uploader service for cache manager
> -----------------------------------------------
>                 Key: YARN-2186
>                 URL: https://issues.apache.org/jira/browse/YARN-2186
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2186-trunk-v1.patch, YARN-2186-trunk-v2.patch, 
> YARN-2186-trunk-v3.patch, YARN-2186-trunk-v4.patch
> Implement the node manager uploader service for the cache manager. This 
> service is responsible for communicating with the node manager when it 
> uploads resources to the shared cache.

This message was sent by Atlassian JIRA

Reply via email to