[ 
https://issues.apache.org/jira/browse/YARN-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190151#comment-14190151
 ] 

Hadoop QA commented on YARN-2677:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12678180/YARN-2677-002.patch
  against trunk revision 179cab8.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5639//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5639//console

This message is automatically generated.

> registry punycoding of usernames doesn't fix all usernames to be DNS-valid
> --------------------------------------------------------------------------
>
>                 Key: YARN-2677
>                 URL: https://issues.apache.org/jira/browse/YARN-2677
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: YARN-2677-001.patch, YARN-2677-002.patch
>
>
> The registry has a restriction "DNS-valid names only" to retain the future 
> option of DNS exporting of the registry.
> to handle complex usernames, it punycodes the username first, using Java's 
> {{java.net.IDN}} class.
> This turns out to only map high unicode-> ASCII, and does nothing for 
> ascii-but-invalid-hostname chars, so stopping users with DNS-illegal names 
> (e.g. with an underscore in them) from being able to register



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to