[ 
https://issues.apache.org/jira/browse/YARN-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190820#comment-14190820
 ] 

Hadoop QA commented on YARN-2766:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12678285/YARN-2766.patch
  against trunk revision c2866ac.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5643//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5643//console

This message is automatically generated.

>  ApplicationHistoryManager is expected to return a sorted list of 
> apps/attempts/containers
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-2766
>                 URL: https://issues.apache.org/jira/browse/YARN-2766
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: 2.6.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: YARN-2766.patch, YARN-2766.patch, YARN-2766.patch, 
> YARN-2766.patch
>
>
> {{TestApplicationHistoryClientService.testContainers}} and 
> {{TestApplicationHistoryClientService.testApplicationAttempts}} both fail 
> because the test assertions are assuming a returned Collection is in a 
> certain order.  The collection comes from a HashMap, so the order is not 
> guaranteed, plus, according to [this 
> page|http://docs.oracle.com/javase/8/docs/technotes/guides/collections/changes8.html],
>  there are situations where the iteration order of a HashMap will be 
> different between Java 7 and 8.
> We should fix the test code to not assume a specific ordering.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to