[ 
https://issues.apache.org/jira/browse/YARN-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192761#comment-14192761
 ] 

Zhijie Shen commented on YARN-2767:
-----------------------------------

[~vvasudev], thanks for the patch. The test cases look good. Just some minor 
comments for code refactoring:

1. Use Assert.fail()?
{code}
      assertTrue("Couldn't create MiniKDC", false);
{code}

2. miniKDCStarted is not necessary.
{code}
      miniKDCStarted = true;
{code}

3. It seems not to be necessary. Maybe we can refactor the code of setUp().
{code}
  private static MiniKdc getKdc() {
    return testMiniKDC;
  }
{code}

> RM web services - add test case to ensure the http static user can kill or 
> submit apps in secure mode
> -----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2767
>                 URL: https://issues.apache.org/jira/browse/YARN-2767
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: apache-yarn-2767.0.patch, apache-yarn-2767.1.patch
>
>
> We should add a test to ensure that the http static user used to access the 
> RM web interface can't submit or kill apps if the cluster is running in 
> secure mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to