Vinod Kumar Vavilapalli commented on YARN-2790:

The patch looks good to me, but I may have found issues with the earlier patch 
at YARN-2704.
 - Once NMs gets new tokens from RM, it will keep on logging info about them 
for every localization and log-agregation for that app.
 - Seems like the system-credentials are never deleted even if the app finishes!

If you agree that these are issues, we can fix them either here or separately.

> NM can't aggregate logs past HDFS delegation token expiry.
> ----------------------------------------------------------
>                 Key: YARN-2790
>                 URL: https://issues.apache.org/jira/browse/YARN-2790
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Tassapol Athiapinya
>            Assignee: Jian He
>         Attachments: YARN-2790.1.patch
> We shorten hdfs delegation token lifetime, set RM to act as as a proxy user 
> in order to be able to renew the token on behalf of a user submitting the 
> application. Still we see NM log aggregation fail due to token expiry error.
> {code}
> 2014-10-31 00:11:56,579 INFO  logaggregation.AppLogAggregatorImpl 
> (AppLogAggregatorImpl.java:finishLogAggregation(481)) - Application just 
> finished : application_1414705229376_0004
> 2014-10-31 00:11:56,588 WARN  ipc.Client (Client.java:run(675)) - Exception 
> encountered while connecting to the server : 
> org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.token.SecretManager$InvalidToken):
>  token (HDFS_DELEGATION_TOKEN token 75 for user1) is expired
> 2014-10-31 00:11:56,589 ERROR logaggregation.AppLogAggregatorImpl 
> (AppLogAggregatorImpl.java:uploadLogsForContainers(233)) - Cannot create 
> writer for app application_1414705229376_0004. Skip log upload this time.
> {code}

This message was sent by Atlassian JIRA

Reply via email to