[ https://issues.apache.org/jira/browse/YARN-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193442#comment-14193442 ]
Hadoop QA commented on YARN-1922: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678706/YARN-1922.5.patch against trunk revision 36ccf09. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5679//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5679//console This message is automatically generated. > Process group remains alive after container process is killed externally > ------------------------------------------------------------------------ > > Key: YARN-1922 > URL: https://issues.apache.org/jira/browse/YARN-1922 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.4.0 > Environment: CentOS 6.4 > Reporter: Billie Rinaldi > Assignee: Billie Rinaldi > Attachments: YARN-1922.1.patch, YARN-1922.2.patch, YARN-1922.3.patch, > YARN-1922.4.patch, YARN-1922.5.patch > > > If the main container process is killed externally, ContainerLaunch does not > kill the rest of the process group. Before sending the event that results in > the ContainerLaunch.containerCleanup method being called, ContainerLaunch > sets the "completed" flag to true. Then when cleaning up, it doesn't try to > read the pid file if the completed flag is true. If it read the pid file, it > would proceed to send the container a kill signal. In the case of the > DefaultContainerExecutor, this would kill the process group. -- This message was sent by Atlassian JIRA (v6.3.4#6332)