[
https://issues.apache.org/jira/browse/YARN-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194207#comment-14194207
]
Vinod Kumar Vavilapalli commented on YARN-2788:
-----------------------------------------------
bq. The problem is what happens if the first read itself runs into EOF. Please
fix that and add a test-case too.
Thinking more, this may not be true. Anyways, better not change what was
working before, so what you have in the latest patch is fine.
Looks good, couple of nits:
- Remove the debug statement: System.out.println("I am hereE:"+
path.getName());
- In the web UI: "Log UpLoad Time: " -> "Log Upload Time:"
> yarn logs -applicationId on 2.6.0 should support logs written by 2.4.0
> ----------------------------------------------------------------------
>
> Key: YARN-2788
> URL: https://issues.apache.org/jira/browse/YARN-2788
> Project: Hadoop YARN
> Issue Type: Bug
> Components: log-aggregation
> Affects Versions: 2.6.0
> Reporter: Gopal V
> Assignee: Xuan Gong
> Priority: Blocker
> Attachments: YARN-2788.1.1.patch, YARN-2788.1.patch,
> YARN-2788.2.patch, YARN-2788.3.patch, YARN-2788.4.patch
>
>
> Log format version needs to be upped between 2.4.0 and 2.6.0
> {code}
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.lang.Long.parseLong(Long.java:589)
> at java.lang.Long.parseLong(Long.java:631)
> at
> org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$ContainerLogsReader.nextLog(AggregatedLogFormat.java:765)
> at
> org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock.readContainerLogs(AggregatedLogsBlock.java:197)
> at
> org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock.render(AggregatedLogsBlock.java:166)
> at
> org.apache.hadoop.yarn.webapp.view.HtmlBlock.render(HtmlBlock.java:67)
> at
> org.apache.hadoop.yarn.webapp.view.HtmlBlock.renderPartial(HtmlBlock.java:77)
> at org.apache.hadoop.yarn.webapp.View.render(View.java:235)
> at
> org.apache.hadoop.yarn.webapp.view.HtmlPage$Page.subView(HtmlPage.java:49)
> at
> org.apache.hadoop.yarn.webapp.hamlet.HamletImpl$EImp._v(HamletImpl.java:117)
> at org.apache.hadoop.yarn.webapp.hamlet.Hamlet$TD._(Hamlet.java:845)
> at
> org.apache.hadoop.yarn.webapp.view.TwoColumnLayout.render(TwoColumnLayout.java:71)
> at
> org.apache.hadoop.yarn.webapp.view.HtmlPage.render(HtmlPage.java:82)
> at
> org.apache.hadoop.yarn.webapp.Controller.render(Controller.java:212)
> at
> org.apache.hadoop.mapreduce.v2.hs.webapp.HsController.logs(HsController.java:178)
> ... 40 more
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
