Craig Welch commented on YARN-2505:


-re 1 and 2, there are two kinds of consistency in play here - with the other 
node label apis and also with current apis in the web service.  There are quite 
a few artifacts in the dao which are working with ids, including node, and they 
don't use "id" to specify it - I think it's assumed as there's no other way to 
refer to them in a web service context except via id.  So, to stay consistent 
with the other web service apis, I don't think we should add "id" to the dao 

As far as the duplication of the put and delete operations on the cluster node 
labels I tend to agree, it seemed like there were too many ways to do that once 
the new api's were added, so I'll remove those.  I do think that the 
/nodes/nodeid/labels apis should stay (I believe you are saying the same thing 
there...) as those are useful for more easily/conveniently working with 
individual nodes.

Will post the updated patch in a few.

> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.1.patch, YARN-2505.11.patch, 
> YARN-2505.12.patch, YARN-2505.13.patch, YARN-2505.14.patch, 
> YARN-2505.3.patch, YARN-2505.4.patch, YARN-2505.5.patch, YARN-2505.6.patch, 
> YARN-2505.7.patch, YARN-2505.8.patch, YARN-2505.9.patch, YARN-2505.9.patch, 
> YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to