Karthik Kambatla commented on YARN-2814:

My notes on items to clean-up from YARN-2579:
# Get rid of RMFatalEventDispatcher and RMFatalEvent* altogether.
# Given all other events are specific to RMActiveServices, we should move the 
dipatcher also into RMActiveServices.
# I am not a fan of having a pointer to the RM in the store as well, 
particularly since we have RMContext primarily to hold the information other 
classes need. I am concerned about more classes needing this information in the 
# Add a shutdownOrTransitionToStandby method in the RM to transparently handle 
non-HA and HA cases.
# Unrelated to this patch: we should make the existing 
transitionToStandby(boolean) private, and add a package-private 
transitionToStandby() to be called from AdminService and EmbeddedElectorService.
# Instead of calling ExitUtil#terminate at multiple places in the RM, we should 
have a protected shutdown() method that does this and can be overridden in 
MockRM for better testing.

> RM: Clean-up the handling of "fatal" events
> -------------------------------------------
>                 Key: YARN-2814
>                 URL: https://issues.apache.org/jira/browse/YARN-2814
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
> YARN-2579 fixes a critical issue around handling fatal events in the RM, but 
> does so minimally. This JIRA is to follow through that approach and do more 
> clean-up.

This message was sent by Atlassian JIRA

Reply via email to