[
https://issues.apache.org/jira/browse/YARN-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202758#comment-14202758
]
Siddharth Seth commented on YARN-2830:
--------------------------------------
+1 for retaining the old newInstance method.
One concern about the patch though - ContainerId will end up with two very
similar methods.
newContainerId(AppAttemptId, int) | Deprecated
newContainerId(AppAttemptId, long)
It's very easy to get these incorrect within YARN itself - which can introduce
some tough to debug issues.
Instead, I think it'll be a lot safer to rename the new method - and retaining
the old one with the old one for compatibility.
> Add backwords compatible ContainerId.newInstance constructor for use within
> Tez Local Mode
> ------------------------------------------------------------------------------------------
>
> Key: YARN-2830
> URL: https://issues.apache.org/jira/browse/YARN-2830
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jonathan Eagles
> Assignee: Jonathan Eagles
> Priority: Blocker
> Attachments: YARN-2830-v1.patch, YARN-2830-v2.patch
>
>
> YARN-2229 modified the private unstable api for constructing. Tez uses this
> api (shouldn't, but does) for use with Tez Local Mode. This causes a
> NoSuchMethod error when using Tez compiled against pre-2.6. Instead I propose
> we add the backwards compatible api since overflow is not a problem in tez
> local mode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
