Zhijie Shen commented on YARN-2505:

I just have one concern about ConverterUtils#toNodeId(). The behavior is 
changed when the arg nodeId string is invalid. It may affect NodeCLI and 
AggregatedLogsBlock when people puts an invalid nodeId string, or the webapp 
generates an url with invalid nodeId string.

BTW, while ConverterUtils is marked \@Private, it's in yarn-common. I'm not 
sure if other components have already make use of this actually useful "APIs".

Any thoughts?

> Support get/add/remove/change labels in RM REST API
> ---------------------------------------------------
>                 Key: YARN-2505
>                 URL: https://issues.apache.org/jira/browse/YARN-2505
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Craig Welch
>         Attachments: YARN-2505.1.patch, YARN-2505.11.patch, 
> YARN-2505.12.patch, YARN-2505.13.patch, YARN-2505.14.patch, 
> YARN-2505.15.patch, YARN-2505.16.patch, YARN-2505.16.patch, 
> YARN-2505.16.patch, YARN-2505.18.patch, YARN-2505.19.patch, 
> YARN-2505.3.patch, YARN-2505.4.patch, YARN-2505.5.patch, YARN-2505.6.patch, 
> YARN-2505.7.patch, YARN-2505.8.patch, YARN-2505.9.patch, YARN-2505.9.patch, 
> YARN-2505.patch

This message was sent by Atlassian JIRA

Reply via email to