Wangda Tan commented on YARN-2056:

Hi [~eepayne],
Thanks for updating the patch and explanation.
I think we should always round-up wQavail to make sure queue with lower 
ideal_assigned percentage will be satisfied first. Instead of {{multiply}} you 
should use {{multiplyAndNormalizeUp}} here. The factor should be resource=(1,1)
Since your patch already sort queues from least satisfied to most satisfied, so 
doing a force round-up here is safe.
Actually I think we should consider minimum_allocation in preemption policy, we 
can address that in a separated JIRA. 

bq. The point of that test was to indicate that preemption levelization will 
still happen even if the thing asking for resources is the one that is 
untouchable. If you think this test is unnecessary, I will take it out.
Since the result is not changed before/after we set preemption queue, I think 
it is unnecessary, I would suggest to take it out.


> Disable preemption at Queue level
> ---------------------------------
>                 Key: YARN-2056
>                 URL: https://issues.apache.org/jira/browse/YARN-2056
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.4.0
>            Reporter: Mayank Bansal
>            Assignee: Eric Payne
>         Attachments: YARN-2056.201408202039.txt, YARN-2056.201408260128.txt, 
> YARN-2056.201408310117.txt, YARN-2056.201409022208.txt, 
> YARN-2056.201409181916.txt, YARN-2056.201409210049.txt, 
> YARN-2056.201409232329.txt, YARN-2056.201409242210.txt, 
> YARN-2056.201410132225.txt, YARN-2056.201410141330.txt, 
> YARN-2056.201410232244.txt, YARN-2056.201410311746.txt, 
> YARN-2056.201411041635.txt, YARN-2056.201411072153.txt, 
> YARN-2056.201411122305.txt, YARN-2056.201411132215.txt
> We need to be able to disable preemption at individual queue level

This message was sent by Atlassian JIRA

Reply via email to