[ 
https://issues.apache.org/jira/browse/YARN-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216806#comment-14216806
 ] 

Karthik Kambatla commented on YARN-2865:
----------------------------------------

Patch looks mostly good. Minor comments - we should reduce the visibility of 
the class and its methods to package-private, mark it @Private @Unstable, and 
add comments that this class is expected to be used only by RMContext and 
ResourceManager. I just want to guard against new code using this instead of 
RMContext; we might want this to be accessible in the future, but we should 
probably keep the changes small in this JIRA.

> Application recovery continuously fails with "Application with id already 
> present. Cannot duplicate"
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2865
>                 URL: https://issues.apache.org/jira/browse/YARN-2865
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Critical
>         Attachments: YARN-2865.patch, YARN-2865.patch
>
>
> YARN-2588 handles exception thrown while transitioningToActive and reset 
> activeServices. But it misses out clearing RMcontext apps/nodes details and 
> ClusterMetrics and QueueMetrics. This causes application recovery to fail.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to