[
https://issues.apache.org/jira/browse/YARN-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218855#comment-14218855
]
Karthik Kambatla commented on YARN-2604:
----------------------------------------
Thanks for the updating the patch. I should have made these comments on the
earlier patch itself:
# findbugs-exclude: there is a duplicate entry there.
# Looking at the current code, I wonder if we should keep all logic about
having two different maximumAllocations should be limited to
AbstractYarnScheduler to avoid mistakes in the future. We can make related
fields all private and accessible only through getter/setter methods.
# {{updateMaxAllocation}} could take a {{Resource}} and a boolean to denote
adding/removing a node, instead of SchedulerNode. That way, we don't have to
iterate through all the nodes in the removeNode case.
> Scheduler should consider max-allocation-* in conjunction with the largest
> node
> -------------------------------------------------------------------------------
>
> Key: YARN-2604
> URL: https://issues.apache.org/jira/browse/YARN-2604
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Affects Versions: 2.5.1
> Reporter: Karthik Kambatla
> Assignee: Robert Kanter
> Attachments: YARN-2604.patch, YARN-2604.patch, YARN-2604.patch,
> YARN-2604.patch
>
>
> If the scheduler max-allocation-* values are larger than the resources
> available on the largest node in the cluster, an application requesting
> resources between the two values will be accepted by the scheduler but the
> requests will never be satisfied. The app essentially hangs forever.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
