[ 
https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218965#comment-14218965
 ] 

Karthik Kambatla commented on YARN-2675:
----------------------------------------

Can we add unit tests to exercise all the newly added transitions? Otherwise, 
the patch looks good. [~vinodkv] - do the changes look okay to you as well? 

> the containersKilled metrics is not updated when the container is killed 
> during localization.
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-2675
>                 URL: https://issues.apache.org/jira/browse/YARN-2675
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2675.000.patch, YARN-2675.001.patch, 
> YARN-2675.002.patch, YARN-2675.003.patch
>
>
> The containersKilled metrics is not updated when the container is killed 
> during localization. We should add KILLING state in finished of 
> ContainerImpl.java to update killedContainer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to