[ 
https://issues.apache.org/jira/browse/YARN-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219196#comment-14219196
 ] 

Hadoop QA commented on YARN-2243:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12682603/YARN-2243.patch
  against trunk revision a9a0cc3.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService

                                      The following test timeouts occurred in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5886//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5886//console

This message is automatically generated.

> Order of arguments for Preconditions.checkNotNull() is wrong in 
> SchedulerApplicationAttempt ctor
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2243
>                 URL: https://issues.apache.org/jira/browse/YARN-2243
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Devaraj K
>            Priority: Minor
>         Attachments: YARN-2243.patch, YARN-2243.patch
>
>
> {code}
>   public SchedulerApplicationAttempt(ApplicationAttemptId 
> applicationAttemptId, 
>       String user, Queue queue, ActiveUsersManager activeUsersManager,
>       RMContext rmContext) {
>     Preconditions.checkNotNull("RMContext should not be null", rmContext);
> {code}
> Order of arguments is wrong for Preconditions.checkNotNull().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to