[ 
https://issues.apache.org/jira/browse/YARN-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mit Desai updated YARN-2375:
----------------------------
    Attachment: YARN-2375.patch

Thanks for taking a look [~zjshen] and [~jeagles].
Attaching updated patch to address Zhijie's comments.

*Additions:*
# In ApplicationMaster.finish(), we now stop the timeline client if the 
timelineClient instance is not null.
# Fixed the indent issue in TimelineClientImpl#serviceInit().
# LOG.info("Timeline server is (not) enabled") changed to LOG.info("Timeline 
service is (not) enabled"); to be consistent with the log statements in other 
places.

I still have not added the test case for testing the scenario if 
MAPREDUCE_JOB_EMIT_TIMELINE_DATA = true and TIMELINE_SERVICE_ENABLED = false; 
MiniMRYarnCluster doesn't start the timeline server.

MiniMRYarnCluster seems to follow a little different path for starting up the 
timeline service. I am investigating that currently. I propose to address that 
in a followup jira. That way we can have the important fix checked in.
If you guys are ok with that, I will file a jira.

> Allow enabling/disabling timeline server per framework
> ------------------------------------------------------
>
>                 Key: YARN-2375
>                 URL: https://issues.apache.org/jira/browse/YARN-2375
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Eagles
>            Assignee: Mit Desai
>         Attachments: YARN-2375.patch, YARN-2375.patch, YARN-2375.patch, 
> YARN-2375.patch
>
>
> This JIRA is to remove the ats enabled flag check within the 
> TimelineClientImpl. Example where this fails is below.
> While running secure timeline server with ats flag set to disabled on 
> resource manager, Timeline delegation token renewer throws an NPE. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to