Karthik Kambatla commented on YARN-2188:

Sorry, didn't realize this patch was updated. Patch looks mostly good. Some 
minor comments:
# Rename yarn.sharedcache.client.server.* to yarn.sharedcache.client-server.*? 
# ClientSCMProtocolPBClientImpl#close should set this.proxy to null.
# In the test, cleanUp() should set variables to null after stopping them. 

> Client service for cache manager
> --------------------------------
>                 Key: YARN-2188
>                 URL: https://issues.apache.org/jira/browse/YARN-2188
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>         Attachments: YARN-2188-trunk-v1.patch, YARN-2188-trunk-v2.patch, 
> YARN-2188-trunk-v3.patch, YARN-2188-trunk-v4.patch
> Implement the client service for the shared cache manager. This service is 
> responsible for handling client requests to use and release resources.

This message was sent by Atlassian JIRA

Reply via email to