[
https://issues.apache.org/jira/browse/YARN-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221334#comment-14221334
]
Jian He commented on YARN-2404:
-------------------------------
Tsuyoshi, thanks for updating the patch ! looks good overall, some minor
comments
- remove following in loadApplicationAttemptState
{code}
ApplicationAttemptId attemptId =
ConverterUtils.toApplicationAttemptId(attemptIDStr);
{code}
- we may change the attemptTokens type to be Credentials. and do the convert
from/to ByteBuffer inside the method, instead of the caller
{code}
public abstract ByteBuffer getAppAttemptTokens();
public abstract void setAppAttemptTokens(ByteBuffer attemptTokens);
{code}
- the following assert is always true
{code}
ApplicationId appId =
appState.getApplicationSubmissionContext().getApplicationId();
// assert child node name is same as actual applicationId
assert appId.equals(
appState.getApplicationSubmissionContext().getApplicationId());
{code}
- the credentials is not used.
{code}
Credentials credentials = null;
if (attemptState.getAppAttemptTokens() != null) {
credentials = new Credentials();
DataInputByteBuffer dibb = new DataInputByteBuffer();
dibb.reset(attemptState.getAppAttemptTokens());
credentials.readTokenStorageStream(dibb);
}
{code}
> Remove ApplicationAttemptState and ApplicationState class in RMStateStore
> class
> --------------------------------------------------------------------------------
>
> Key: YARN-2404
> URL: https://issues.apache.org/jira/browse/YARN-2404
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Tsuyoshi OZAWA
> Attachments: YARN-2404.1.patch, YARN-2404.2.patch, YARN-2404.3.patch,
> YARN-2404.4.patch, YARN-2404.5.patch, YARN-2404.6.patch
>
>
> We can remove ApplicationState and ApplicationAttemptState class in
> RMStateStore, given that we already have ApplicationStateData and
> ApplicationAttemptStateData records. we may just replace ApplicationState
> with ApplicationStateData, similarly for ApplicationAttemptState.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
