[
https://issues.apache.org/jira/browse/YARN-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221513#comment-14221513
]
Sandy Ryza commented on YARN-2669:
----------------------------------
This is looking good. A few comments.
Can we add documentation for this behavior in FairScheduler.apt.vm?
We should be doing the same conversion for group names, right?
{code}
+ + " submitted by user " + user + " with an illegal queue name ("
+ + queueName + "). "
{code}
Nit: I think it's better not to surround the queue name with parentheses.
{code}
+ return queueName + "." + convertUsername(user);
{code}
Can we call convertUsername something like cleanUsername to be a little more
descriptive?
> FairScheduler: queueName shouldn't allow periods the allocation.xml
> -------------------------------------------------------------------
>
> Key: YARN-2669
> URL: https://issues.apache.org/jira/browse/YARN-2669
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Wei Yan
> Assignee: Wei Yan
> Priority: Minor
> Attachments: YARN-2669-1.patch, YARN-2669-2.patch, YARN-2669-3.patch,
> YARN-2669-4.patch
>
>
> For an allocation file like:
> {noformat}
> <allocations>
> <queue name="root.q1">
> <minResources>4096mb,4vcores</minResources>
> </queue>
> </allocations>
> {noformat}
> Users may wish to config minResources for a queue with full path "root.q1".
> However, right now, fair scheduler will treat this configureation for the
> queue with full name "root.root.q1". We need to print out a warning msg to
> notify users about this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
