[ 
https://issues.apache.org/jira/browse/YARN-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222439#comment-14222439
 ] 

Hadoop QA commented on YARN-2869:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12682931/YARN-2869-2.patch
  against trunk revision a4df9ee.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
19 warning messages.
        See 
https://builds.apache.org/job/PreCommit-YARN-Build/5908//artifact/patchprocess/diffJavadocWarnings.txt
 for details.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client:

                  
org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5908//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5908//console

This message is automatically generated.

> CapacityScheduler should trim sub queue names when parse configuration
> ----------------------------------------------------------------------
>
>                 Key: YARN-2869
>                 URL: https://issues.apache.org/jira/browse/YARN-2869
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2869-1.patch, YARN-2869-2.patch
>
>
> Currently, capacity scheduler doesn't trim sub queue name when parsing queue 
> names, for example, the configuration
> {code}
> <configuration>
>      <property>
>          <name>...root.queues</name>
>          <value> a, b  , c</value>
>      </property>
>      <property>
>          <name>...root.b.capacity</name>
>          <value>100</value>
>      </property>
>       
>      .......
> </property>
> {code}
> Will fail with error: 
> {code}
> java.lang.IllegalArgumentException: Illegal capacity of -1.0 for queue root. 
> a 
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerConfiguration.getCapacity(CapacitySchedulerConfiguration.java:332)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.getCapacityFromConf(LeafQueue.java:196)
>         ....
> {code}
> It will try to find a queues with name " a", " b  ", and " c", which is 
> apparently wrong, we should do trimming on these sub queue names.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to