[ 
https://issues.apache.org/jira/browse/YARN-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225098#comment-14225098
 ] 

Zhijie Shen commented on YARN-2900:
-----------------------------------

Thanks for the patch. Here're some comments:

1. In ApplicationHistoryManagerOnTimelineStore, we need to take care of 
ApplicationAttemptNotFoundException and ContainerNotFoundException too.

2. In ApplicationHistoryClientService, we should throw the aforementioned 
exception correspondingly.

3. Please check what's the caller of getApplication. Make sure NPE won't happen 
when returning null.

4. In TestApplicationHistoryClientService and TestAHSWebServices, can we add 
the test cases to cover the not found code path for get app|attempt|container?

> Application (Attempt and Container) Not Found in AHS results in Internal 
> Server Error (500)
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-2900
>                 URL: https://issues.apache.org/jira/browse/YARN-2900
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Eagles
>            Assignee: Mit Desai
>         Attachments: YARN-2900.patch, YARN-2900.patch
>
>
> Caused by: java.lang.NullPointerException
>       at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryManagerImpl.convertToApplicationReport(ApplicationHistoryManagerImpl.java:128)
>       at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryManagerImpl.getApplication(ApplicationHistoryManagerImpl.java:118)
>       at 
> org.apache.hadoop.yarn.server.webapp.WebServices$2.run(WebServices.java:222)
>       at 
> org.apache.hadoop.yarn.server.webapp.WebServices$2.run(WebServices.java:219)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:415)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1679)
>       at 
> org.apache.hadoop.yarn.server.webapp.WebServices.getApp(WebServices.java:218)
>       ... 59 more



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to