[ 
https://issues.apache.org/jira/browse/YARN-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226496#comment-14226496
 ] 

Junping Du commented on YARN-2907:
----------------------------------

Thanks [~rohithsharma] for the patch and [~ajisakaa] for review! 
The patch looks good in overall. A quick improvement is to add a unit test to 
test the toString() is some result what we expect.

> SchedulerNode#toString should print all resource detail instead of only 
> memory.
> -------------------------------------------------------------------------------
>
>                 Key: YARN-2907
>                 URL: https://issues.apache.org/jira/browse/YARN-2907
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Trivial
>         Attachments: 0001-YARN-2907.patch
>
>
> SchedulerNode#toString display only memory. It should display both memory and 
> cpu. It helps while analyzing logs
> {code}
>   @Override
>   public String toString() {
>     return "host: " + rmNode.getNodeAddress() + " #containers="
>         + getNumContainers() + " available="
>         + getAvailableResource().getMemory() + " used="
>         + getUsedResource().getMemory();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to