[ 
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226633#comment-14226633
 ] 

Zhijie Shen commented on YARN-2890:
-----------------------------------

Thanks for the patch, Mit!

1. It makes sense to rely on the config to determine if we want to start the 
timeline server in mini YARN cluster. If we're going to do so, MiniYARNCluster 
constructor with enableAHS param is not longer useful. We can remove it.
{code}
  public MiniYARNCluster(
      String testName, int numResourceManagers, int numNodeManagers,
      int numLocalDirs, int numLogDirs, boolean enableAHS) {
{code}

2. This case is covered already by the other tests. I think we are supposed to 
cover TIMELINE_SERVICE_ENABLED = false and MAPREDUCE_JOB_EMIT_TIMELINE_DATA = 
true and false.
{code}
+    conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true);
+    conf.setBoolean(MRJobConfig.MAPREDUCE_JOB_EMIT_TIMELINE_DATA, true);
{code}

> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>
>                 Key: YARN-2890
>                 URL: https://issues.apache.org/jira/browse/YARN-2890
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>             Fix For: 2.6.1
>
>         Attachments: YARN-2890.patch, YARN-2890.patch
>
>
> Currently the MiniMRYarnCluster does not consider the configuration value for 
> enabling timeline service before starting. The MiniYarnCluster should only 
> start the timeline service if it is configured to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to