Varun Saxena commented on YARN-2748:

Thanks [~zjshen] for the review.

Well the patch I have given looks at all the sub folders recursively and hence 
will work for single-level sub folder scenario as well.
Do you see any issue with looking for sub-folders recursively ?

I have added a test case for only a single-level sub folder though. I will add 
a case where multiple-level subfolders exist.

> Upload logs in the sub-folders under the local log dir when aggregating logs
> ----------------------------------------------------------------------------
>                 Key: YARN-2748
>                 URL: https://issues.apache.org/jira/browse/YARN-2748
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: log-aggregation
>    Affects Versions: 2.6.0
>            Reporter: Zhijie Shen
>            Assignee: Varun Saxena
>             Fix For: 2.7.0
>         Attachments: YARN-2748.001.patch
> YARN-2734 has a temporal fix to skip sub folders to avoid exception. Ideally, 
> if the app is creating a sub folder and putting its rolling logs there, we 
> need to upload these logs as well.

This message was sent by Atlassian JIRA

Reply via email to