[
https://issues.apache.org/jira/browse/YARN-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231764#comment-14231764
]
Hadoop QA commented on YARN-2674:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12684681/YARN-2674.2.patch
against trunk revision 75d5345.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/5978//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/5978//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-applications-distributedshell.html
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5978//console
This message is automatically generated.
> Distributed shell AM may re-launch containers if RM work preserving restart
> happens
> -----------------------------------------------------------------------------------
>
> Key: YARN-2674
> URL: https://issues.apache.org/jira/browse/YARN-2674
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Chun Chen
> Attachments: YARN-2674.1.patch, YARN-2674.2.patch
>
>
> Currently, if RM work preserving restart happens while distributed shell is
> running, distribute shell AM may re-launch all the containers, including
> new/running/complete. We must make sure it won't re-launch the
> running/complete containers.
> We need to remove allocated containers from
> AMRMClientImpl#remoteRequestsTable once AM receive them from RM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
