[
https://issues.apache.org/jira/browse/YARN-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232371#comment-14232371
]
Karthik Kambatla commented on YARN-2189:
----------------------------------------
Thanks Chris. Sorry for the delay, I managed to miss this patch too. Will try
to keep up better. Some comments on the patch:
# Mismatch between YarnConfiguration and yarn-default for the thread-count
config. I like the version in yarn-default better.
# Is SCMAdmin#getUGI required? If not, I would get rid of it.
# SCMAdmin#run - I don't see the value in handling number of arguments in a
different if-block. Also, not a fan of setting exitCode to -1 and 0, only to be
overwritten later. Also, one of the else-blocks has a duplicate
{{printUsage("")}} call.
# Unused import in SCMAdminProtocolPBClientImpl
# SCMAdminProtocolService#serviceInit has two blank lines - should remove at
least one and preferably both.
# SCMAdminProtocolService#checkAcls could use RMServerUtils#verifyAccess.
# Other servers in YARN have a command-line check in unit tests. See RMAdmin
for instance. I am not particular about having as specific a test, but it would
be nice to check if the messages contain important responses.
> Admin service for cache manager
> -------------------------------
>
> Key: YARN-2189
> URL: https://issues.apache.org/jira/browse/YARN-2189
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Attachments: YARN-2189-trunk-v1.patch, YARN-2189-trunk-v2.patch,
> YARN-2189-trunk-v3.patch, YARN-2189-trunk-v4.patch, YARN-2189-trunk-v5.patch
>
>
> Implement the admin service for the shared cache manager. This service is
> responsible for handling administrative commands such as manually running a
> cleaner task.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
