[
https://issues.apache.org/jira/browse/YARN-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233672#comment-14233672
]
Tsuyoshi OZAWA commented on YARN-2800:
--------------------------------------
[~wangda] thanks for your update! Minor nits:
{code}
+ public static final String NODE_LABELS_NOT_ENABLED_ERR = "Node labels not "
+ + "enabled, you cannot make any changes on node labels, you can set "
+ + YarnConfiguration.NODE_LABELS_ENABLED
+ + " to true to enable this feature, please reference to user guide.";
{code}
I think we should simplify the error message. How about fixing like this?
{code}
"Label-based scheduling is disabled. Please check " +
YarnConfiguration.NODE_LABELS_ENABLED;
{code}
> Remove MemoryNodeLabelsStore and add a way to enable/disable node labels
> feature
> --------------------------------------------------------------------------------
>
> Key: YARN-2800
> URL: https://issues.apache.org/jira/browse/YARN-2800
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client, resourcemanager
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-2800-20141102-1.patch, YARN-2800-20141102-2.patch,
> YARN-2800-20141118-1.patch, YARN-2800-20141118-2.patch,
> YARN-2800-20141119-1.patch
>
>
> In the past, we have a MemoryNodeLabelStore, mostly for user to try this
> feature without configuring where to store node labels on file system. It
> seems convenient for user to try this, but actually it causes some bad use
> experience. User may add/remove labels, and edit capacity-scheduler.xml.
> After RM restart, labels will gone, (we store it in mem). And RM cannot get
> started if we have some queue uses labels, and the labels don't exist in
> cluster.
> As what we discussed, we should have an explicitly way to let user specify if
> he/she wants this feature or not. If node label is disabled, any operations
> trying to modify/use node labels will throw exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
