Rohith commented on YARN-2762:

bq. If no node-to-labels mapping specified when replace labels, the message is 
"No node-to-labels mappings are specified"
Do you mean validation check for variable map i.e {{Map<NodeId, Set<String>> 
map = new HashMap<NodeId, Set<String>>();}} should be done not only for 
map.isEmpty but also for map values i.e set individually? If so, what if input 
string is *host1:port,, host2:port,x*?

> RMAdminCLI node-labels-related args should be trimmed and checked before 
> sending to RM
> --------------------------------------------------------------------------------------
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.patch
> All NodeLabel args validation's are done at server side. The same can be done 
> at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can 
> be skipped.

This message was sent by Atlassian JIRA

Reply via email to