[ 
https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233975#comment-14233975
 ] 

Varun Saxena commented on YARN-2914:
------------------------------------

Thanks for the comments [~ctrezzo] and [~ozawa]. I will update a patch for 
this. Code is similar in CleanerMetrics as well.

> Potential race condition in 
> SharedCacheUploaderMetrics/ClientSCMMetrics#getInstance()
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2914
>                 URL: https://issues.apache.org/jira/browse/YARN-2914
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ted Yu
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-2914.patch
>
>
> {code}
>   public static ClientSCMMetrics getInstance() {
>     ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl;
>     if (topMetrics == null) {
>       throw new IllegalStateException(
> {code}
> getInstance() doesn't hold lock on Singleton.this
> This may result in IllegalStateException being thrown prematurely.
> [~ctrezzo] reported that SharedCacheUploaderMetrics has also same kind of 
> race condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to