[ 
https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234526#comment-14234526
 ] 

Wangda Tan commented on YARN-2762:
----------------------------------

[~rohithsharma],
The Jenkins should have some issues, I've uploaded several patches yesterday, 
but none of them get ran.

One comment is, could you please merge same error message to a final field of 
RMAdminCLI, like 
{code}
   static final String NO_LABEL = "xxxxxx"
{code}

Thanks,

> RMAdminCLI node-labels-related args should be trimmed and checked before 
> sending to RM
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, 
> YARN-2762.3.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done 
> at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can 
> be skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to