[
https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235901#comment-14235901
]
Wangda Tan commented on YARN-2925:
----------------------------------
Hi [~sunilg],
No, I didn't intent to remove the CS lock, actually when trying to getHeadroom
from FiCaSchedulerApp side, there was no CS lock, what we should do is protect
internal fields for resources in LeafQueue, which described above:
bq. Adding a fine-grained lock in LeafQueue, only protect resource/capacity
related fields. With this, fields could be protected and CS lock will be
avoided altogether
> Internal fields in LeafQueue access should be protected when accessed from
> FiCaSchedulerApp to calculate Headroom
> -----------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2925
> URL: https://issues.apache.org/jira/browse/YARN-2925
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacityscheduler
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Priority: Critical
>
> Upon YARN-2644, FiCaScheduler will calculation up-to-date headroom before
> sending back Allocation response to AM.
> Headroom calculation is happened in LeafQueue side, uses fields like used
> resource, etc. But it is not protected by any lock of LeafQueue, so it might
> be corrupted is someone else is editing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
