Hadoop QA commented on YARN-2927:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against trunk revision 475c6b4.

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6011//console

This message is automatically generated.

> YARN InMemorySCMStore properties need fixing
> --------------------------------------------
>                 Key: YARN-2927
>                 URL: https://issues.apache.org/jira/browse/YARN-2927
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: newbie, supportability
>         Attachments: YARN-2927.001.patch, YARN-2927.002.patch
> I see these properties in the yarn-default.xml file:
>   yarn.sharedcache.store.in-memory.check-period-mins
>   yarn.sharedcache.store.in-memory.initial-delay-mins
>   yarn.sharedcache.store.in-memory.staleness-period-mins
> YarnConfiguration looks like it's missing some properties:
>   public static final String SHARED_CACHE_PREFIX = "yarn.sharedcache.";
>   public static final String SCM_STORE_PREFIX = SHARED_CACHE_PREFIX + 
> "store.";
>   public static final String IN_MEMORY_STORE_PREFIX = SHARED_CACHE_PREFIX + 
> "in-memory.";
>   public static final String IN_MEMORY_STALENESS_PERIOD_MINS = 
> IN_MEMORY_STORE_PREFIX + "staleness-period-mins";
> It looks like the definition for IN_MEMORY_STORE_PREFIX should be:
>   public static final String IN_MEMORY_STORE_PREFIX = SCM_STORE_PREFIX + 
> "in-memory.";
> Just to be clear, there are properties that exist in yarn-default.xml that 
> are effectively misspelled in the *Java* file, not the .xml file.  This is 
> similar to YARN-2461 and MAPREDUCE-6087.

This message was sent by Atlassian JIRA

Reply via email to