[ 
https://issues.apache.org/jira/browse/YARN-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236631#comment-14236631
 ] 

Rohith commented on YARN-2762:
------------------------------

bq. Better we can use labels.isEmpty()
Make sense,  I will do change

bq. I feel other exception message also can be made similar to NO_LABEL if no 
issues.
This can be done in another jira.

bq. Could tests be updated to verify exceptions which are raised on empty 
cluster node-labels?
All the excptions are printed on console. None of these were thrown back from 
run(). I have verified console message.I think it should be fine to verify only 
return code from test.

> RMAdminCLI node-labels-related args should be trimmed and checked before 
> sending to RM
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-2762
>                 URL: https://issues.apache.org/jira/browse/YARN-2762
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Rohith
>            Assignee: Rohith
>            Priority: Minor
>         Attachments: YARN-2762.1.patch, YARN-2762.2.patch, YARN-2762.2.patch, 
> YARN-2762.3.patch, YARN-2762.4.patch, YARN-2762.patch
>
>
> All NodeLabel args validation's are done at server side. The same can be done 
> at RMAdminCLI so that unnecessary RPC calls can be avoided.
> And for the input such as "x,y,,z,", no need to add empty string instead can 
> be skipped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to