[ 
https://issues.apache.org/jira/browse/YARN-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243409#comment-14243409
 ] 

Tsuyoshi OZAWA commented on YARN-2243:
--------------------------------------

Good catch, +1.

>From the javadoc of [Google 
>Guava|https://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Preconditions.html]:
{code}
checkArgument(boolean expression, Object errorMessage) 
{code}

> Order of arguments for Preconditions.checkNotNull() is wrong in 
> SchedulerApplicationAttempt ctor
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2243
>                 URL: https://issues.apache.org/jira/browse/YARN-2243
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.5.1
>            Reporter: Ted Yu
>            Assignee: Devaraj K
>            Priority: Minor
>         Attachments: YARN-2243.patch, YARN-2243.patch
>
>
> {code}
>   public SchedulerApplicationAttempt(ApplicationAttemptId 
> applicationAttemptId, 
>       String user, Queue queue, ActiveUsersManager activeUsersManager,
>       RMContext rmContext) {
>     Preconditions.checkNotNull("RMContext should not be null", rmContext);
> {code}
> Order of arguments is wrong for Preconditions.checkNotNull().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to