[ 
https://issues.apache.org/jira/browse/YARN-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245969#comment-14245969
 ] 

Rohith commented on YARN-2952:
------------------------------

Test case failure and findbug warning are unrelated to this patch.

> Incorrect version check in RMStateStore
> ---------------------------------------
>
>                 Key: YARN-2952
>                 URL: https://issues.apache.org/jira/browse/YARN-2952
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Rohith
>         Attachments: 0001-YARN-2952.patch
>
>
> In RMStateStore#checkVersion:  if we modify  tCURRENT_VERSION_INFO to 2.0, 
> it'll still store the version as 1.0 which is incorrect; The same thing might 
> happen to NM store, timeline store.
> {code}
>     // if there is no version info, treat it as 1.0;
>     if (loadedVersion == null) {
>       loadedVersion = Version.newInstance(1, 0);
>     }
>     if (loadedVersion.isCompatibleTo(getCurrentVersion())) {
>       LOG.info("Storing RM state version info " + getCurrentVersion());
>       storeVersion();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to