Varun Vasudev updated YARN-2949:
    Attachment: apache-yarn-2949.1.patch

Uploaded a new patch to address Junping's comments.

bq. 1. There are many related configuration properties for enabling/configuring 
CGroups, these properties are coming from yarn-site.xml (or yarn-default.xml) 
or container-executor.cfg. Please explain explicitly on where user should put 
these properties.

Fixed. All the properties go in yarn-site.xml. I added a line specifying that. 
I also removed reference to yarn-default.xml since they were confusing.

bq. 2. I like the discussion for session of CGroups and security, and it would 
be great to provide an example for configuration w/o security. (nice to have).

I added a table explaining the behaviour further. Let me know if that's ok.

3. Several typos:

    typo of CGgroups", should be "CGroups"
    typo of "In our cause", should be "in our case"

Thanks for catching them! Fixed. I'll upload the html generated once I get an 
ok from Jenkins.

> Add documentation for CGroups
> -----------------------------
>                 Key: YARN-2949
>                 URL: https://issues.apache.org/jira/browse/YARN-2949
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: documentation, nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: NodeManagerCgroups.html, apache-yarn-2949.0.patch, 
> apache-yarn-2949.1.patch
> A bunch of changes have gone into the NodeManager to allow greater use of 
> CGroups. It would be good to have a single page that documents how to setup 
> CGroups and the controls available.

This message was sent by Atlassian JIRA

Reply via email to